From 3734a7eda89cdaa432709c226da75a71533fc03c Mon Sep 17 00:00:00 2001 From: "kfraser@localhost.localdomain" Date: Fri, 27 Apr 2007 15:12:48 +0100 Subject: [PATCH] xend: Don't use -q flag to bootloader if activating text console. In Xen 3.0.3 series release, if one did 'xm create -c someguest' then you would be shown the pygrub boot menu, allowing one to pick a kernel. If you didn't use the -c arg, then it'd just pick the default kernel. In Xen 3.0.5 testing, xm is forcing the addition of the '-q' flag whenever the 'bootargs' parameter is not given in the config file. So if one does not have 'bootargs' specified, and one uses 'xm create -c someguest' you never get to see the pygrub boot menu. This patch fixes 'xm create' so that it does not add the '-q' flag to the bootloader args, if the '-c' flag is given to xm create. This makes the default user experiance operate closer to user expectations. Signed-off-by: Daniel P. Berrange --- tools/python/xen/xm/create.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/python/xen/xm/create.py b/tools/python/xen/xm/create.py index 5b4577c407..79fa947bb6 100644 --- a/tools/python/xen/xm/create.py +++ b/tools/python/xen/xm/create.py @@ -777,8 +777,11 @@ def make_config(vals): config.append(['bootloader', vals.bootloader]) if vals.bootargs: config.append(['bootloader_args', vals.bootargs]) - else: - config.append(['bootloader_args', '-q']) + else: + if vals.console_autoconnect: + config.append(['bootloader_args', '']) + else: + config.append(['bootloader_args', '-q']) config.append(['image', config_image]) config_devs = [] -- 2.30.2